refactor: replace sudo_prefix with run_as_root abstraction#18
Merged
ethannortharc merged 1 commit intomainfrom Mar 11, 2026
Merged
refactor: replace sudo_prefix with run_as_root abstraction#18ethannortharc merged 1 commit intomainfrom
ethannortharc merged 1 commit intomainfrom
Conversation
…bstraction The previous sudo_prefix() approach prepended "sudo" before individual commands, but sudo strips environment variables — so commands like "export NIX_PATH=... && sudo nixos-rebuild switch" lost NIX_PATH across the sudo boundary, breaking Lima/macOS provisioning. New approach: Runtime::run_as_root(name, cmd) wraps the ENTIRE command inside the sudo boundary: - Incus: bash -lc <cmd> (already root, login shell for PATH) - Lima: sudo bash -lc <cmd> (elevate entire invocation) This keeps env vars, PATH, and privilege escalation all within one consistent boundary. Removes sudo_prefix() entirely. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudo_prefix()string-prepend approach withRuntime::run_as_root(name, cmd)sudo_prefix()putsudobefore individual commands, but sudo strips env vars —export NIX_PATH=... && sudo nixos-rebuild switchlost NIX_PATH, breaking Lima/macOS provisioningrun_as_root()wraps the entire command inside the sudo boundary:bash -lc <cmd>(already root)sudo bash -lc <cmd>(elevate entire invocation, env vars preserved)provision.rs,overlay.rs,nix/rebuild.rsTest plan
cargo buildsucceedscargo test— all 67 tests passdevbox destroy --name test2 && devbox create --name test2 --tools rust,godevbox destroy --name hive-dev && devbox create --name hive-dev --tools go🤖 Generated with Claude Code